Add tenant-scoped personal memory facts

This commit is contained in:
Jacob Dubin
2026-05-05 22:40:11 -05:00
parent 687ff62f0f
commit 699e0d5282
10 changed files with 525 additions and 19 deletions

View File

@@ -1,5 +1,7 @@
using Jibo.Cloud.Application.Abstractions;
using Jibo.Cloud.Application.Services;
using Jibo.Cloud.Infrastructure.Content;
using Jibo.Cloud.Infrastructure.Persistence;
using Jibo.Runtime.Abstractions;
using System.Text.Json;
@@ -136,6 +138,114 @@ public sealed class JiboInteractionServiceTests
Assert.Equal("I do. I am curious, playful, and always up for a new experiment.", decision.ReplyText);
}
[Fact]
public async Task BuildDecisionAsync_BirthdayMemory_SetThenRecallWithinTenant()
{
var memoryStore = new InMemoryPersonalMemoryStore();
var service = CreateService(memoryStore);
var setDecision = await service.BuildDecisionAsync(new TurnContext
{
RawTranscript = "my birthday is April 12",
NormalizedTranscript = "my birthday is April 12",
Attributes = new Dictionary<string, object?>
{
["accountId"] = "acct-a",
["loopId"] = "loop-a"
},
DeviceId = "device-a"
});
Assert.Equal("memory_set_birthday", setDecision.IntentName);
Assert.Equal("Got it. I will remember your birthday is april 12.", setDecision.ReplyText);
var recallDecision = await service.BuildDecisionAsync(new TurnContext
{
RawTranscript = "when is my birthday",
NormalizedTranscript = "when is my birthday",
Attributes = new Dictionary<string, object?>
{
["accountId"] = "acct-a",
["loopId"] = "loop-a"
},
DeviceId = "device-a"
});
Assert.Equal("memory_get_birthday", recallDecision.IntentName);
Assert.Equal("You told me your birthday is april 12.", recallDecision.ReplyText);
}
[Fact]
public async Task BuildDecisionAsync_PreferenceMemory_SetThenRecallWithinTenant()
{
var memoryStore = new InMemoryPersonalMemoryStore();
var service = CreateService(memoryStore);
var setDecision = await service.BuildDecisionAsync(new TurnContext
{
RawTranscript = "my favorite music is jazz",
NormalizedTranscript = "my favorite music is jazz",
Attributes = new Dictionary<string, object?>
{
["accountId"] = "acct-a",
["loopId"] = "loop-a"
},
DeviceId = "device-a"
});
Assert.Equal("memory_set_preference", setDecision.IntentName);
Assert.Equal("Got it. I will remember your favorite music is jazz.", setDecision.ReplyText);
var recallDecision = await service.BuildDecisionAsync(new TurnContext
{
RawTranscript = "what is my favorite music",
NormalizedTranscript = "what is my favorite music",
Attributes = new Dictionary<string, object?>
{
["accountId"] = "acct-a",
["loopId"] = "loop-a"
},
DeviceId = "device-a"
});
Assert.Equal("memory_get_preference", recallDecision.IntentName);
Assert.Equal("You told me your favorite music is jazz.", recallDecision.ReplyText);
}
[Fact]
public async Task BuildDecisionAsync_PersonalMemory_IsTenantScoped()
{
var memoryStore = new InMemoryPersonalMemoryStore();
var service = CreateService(memoryStore);
await service.BuildDecisionAsync(new TurnContext
{
RawTranscript = "my birthday is April 12",
NormalizedTranscript = "my birthday is April 12",
Attributes = new Dictionary<string, object?>
{
["accountId"] = "acct-a",
["loopId"] = "loop-a"
},
DeviceId = "device-a"
});
var otherTenantRecall = await service.BuildDecisionAsync(new TurnContext
{
RawTranscript = "what is my birthday",
NormalizedTranscript = "what is my birthday",
Attributes = new Dictionary<string, object?>
{
["accountId"] = "acct-b",
["loopId"] = "loop-a"
},
DeviceId = "device-b"
});
Assert.Equal("memory_get_birthday", otherTenantRecall.IntentName);
Assert.Equal("I do not know your birthday yet. You can say, my birthday is March 14.", otherTenantRecall.ReplyText);
}
[Fact]
public async Task BuildDecisionAsync_MakePizza_UsesOriginalMimStylePayload()
{
@@ -1185,11 +1295,12 @@ public sealed class JiboInteractionServiceTests
Assert.Equal("aglet", decision.SkillPayload!["guess"]);
}
private static JiboInteractionService CreateService()
private static JiboInteractionService CreateService(IPersonalMemoryStore? personalMemoryStore = null)
{
return new JiboInteractionService(
new JiboExperienceContentCache(new InMemoryJiboExperienceContentRepository()),
new FirstItemRandomizer());
new FirstItemRandomizer(),
personalMemoryStore ?? new InMemoryPersonalMemoryStore());
}
private sealed class FirstItemRandomizer : IJiboRandomizer

View File

@@ -18,7 +18,7 @@ public sealed class JiboWebSocketServiceTests
_store = new InMemoryCloudStateStore();
var contentRepository = new InMemoryJiboExperienceContentRepository();
var contentCache = new JiboExperienceContentCache(contentRepository);
var conversationBroker = new DemoConversationBroker(new JiboInteractionService(contentCache, new DefaultJiboRandomizer()));
var conversationBroker = new DemoConversationBroker(new JiboInteractionService(contentCache, new DefaultJiboRandomizer(), new InMemoryPersonalMemoryStore()));
var sttSelector = new DefaultSttStrategySelector(
[
new SyntheticBufferedAudioSttStrategy()
@@ -2906,6 +2906,74 @@ public sealed class JiboWebSocketServiceTests
Assert.Equal("AN", meta.GetProperty("prompt_sub_category").GetString());
}
[Fact]
public async Task ClientAsrPersonalMemory_BirthdayIsScopedPerDeviceTenant()
{
var tokenA = _store.IssueRobotToken("tenant-device-a");
var tokenB = _store.IssueRobotToken("tenant-device-b");
var setReplies = await _service.HandleMessageAsync(new WebSocketMessageEnvelope
{
HostName = "neo-hub.jibo.com",
Path = "/listen",
Kind = "neo-hub-listen",
Token = tokenA,
Text = """{"type":"CLIENT_ASR","transID":"trans-memory-set","data":{"text":"my birthday is april 12"}}"""
});
Assert.Equal(3, setReplies.Count);
using (var setListenPayload = JsonDocument.Parse(setReplies[0].Text!))
{
Assert.Equal("memory_set_birthday", setListenPayload.RootElement.GetProperty("data").GetProperty("nlu").GetProperty("intent").GetString());
}
var sameTenantRecallReplies = await _service.HandleMessageAsync(new WebSocketMessageEnvelope
{
HostName = "neo-hub.jibo.com",
Path = "/listen",
Kind = "neo-hub-listen",
Token = tokenA,
Text = """{"type":"CLIENT_ASR","transID":"trans-memory-recall-a","data":{"text":"what is my birthday"}}"""
});
Assert.Equal(3, sameTenantRecallReplies.Count);
using (var skillPayload = JsonDocument.Parse(sameTenantRecallReplies[2].Text!))
{
var esml = skillPayload.RootElement
.GetProperty("data")
.GetProperty("action")
.GetProperty("config")
.GetProperty("jcp")
.GetProperty("config")
.GetProperty("play")
.GetProperty("esml")
.GetString();
Assert.Contains("You told me your birthday is april 12", esml, StringComparison.OrdinalIgnoreCase);
}
var otherTenantRecallReplies = await _service.HandleMessageAsync(new WebSocketMessageEnvelope
{
HostName = "neo-hub.jibo.com",
Path = "/listen",
Kind = "neo-hub-listen",
Token = tokenB,
Text = """{"type":"CLIENT_ASR","transID":"trans-memory-recall-b","data":{"text":"what is my birthday"}}"""
});
Assert.Equal(3, otherTenantRecallReplies.Count);
using var otherSkillPayload = JsonDocument.Parse(otherTenantRecallReplies[2].Text!);
var otherEsml = otherSkillPayload.RootElement
.GetProperty("data")
.GetProperty("action")
.GetProperty("config")
.GetProperty("jcp")
.GetProperty("config")
.GetProperty("play")
.GetProperty("esml")
.GetString();
Assert.Contains("I do not know your birthday yet", otherEsml, StringComparison.OrdinalIgnoreCase);
}
[Fact]
public async Task FollowUpTurn_UsesNewTurnStateWithoutLeakingBufferedAudio()
{